Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Add image support to the Pillar component #836

Open
seangolob opened this issue Nov 26, 2024 · 2 comments · May be fixed by #862
Open

[Feature request] Add image support to the Pillar component #836

seangolob opened this issue Nov 26, 2024 · 2 comments · May be fixed by #862
Assignees
Labels

Comments

@seangolob
Copy link

Hi PB team!

The discussions page has a few pillars that have images in them.

Image

Currently, these are custom built and I am curious if we should standardize this feature.

What do y'all think about adding this feature into the Pillar component? I was thinking that a <Pillar.Image /> component could be made to support something like this.

As always, thank you for your hard work and support! ❤

CC @jesussandreas @simmonsjenna

@natalie-iv
Copy link

natalie-iv commented Dec 3, 2024

We would like to keep the rules for “pillars with images” same as for “cards with images” + a rule Avoid using Pillars with Images for groups of 6+ items; stick to groups of 3–6. . We also would recommend not to put sections with 6 pillars with images right after each other to avoid page looking like a blog posts overview.

the following rules from cards with images will apply as well:

Image
Image
Image

@rezrah
Copy link
Collaborator

rezrah commented Dec 9, 2024

We're ready to move forward with this request based on the Site guidance above ☝. Thanks @natalie-iv @jesussandreas

@rezrah rezrah added the brand label Dec 9, 2024
@danielguillan danielguillan linked a pull request Dec 12, 2024 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants