Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't have markdown lists in codesurfer steps? #84

Open
andycmaj opened this issue Mar 23, 2020 · 1 comment
Open

can't have markdown lists in codesurfer steps? #84

andycmaj opened this issue Mar 23, 2020 · 1 comment

Comments

@andycmaj
Copy link

my deck.mdx:

import { CodeSurfer, CodeSurferColumns, Step } from "code-surfer";

<CodeSurferColumns>

<Step>

<div>

Yarn workspaces list.

" for the remainder of the tour, `~` will refer to the monorepo root.

This is the list of all applications and libraries contained in the monorepo.
Each workspace in this list will have their `node_modules` symlinked back to `~/node_modules`.

`yarn install` at `~` will install dependencies for all workspaces.

### reference

* [yarn workspaces docs](https://classic.yarnpkg.com/en/docs/workspaces/)

</div>

```ts title="package.json" file="../package.json"
```

error running mdx-deck:

unknown: Expected corresponding JSX closing tag for <li> (18:131)

  16 | <h3>{`reference`}</h3>
  17 | <ul>
> 18 | <li parentName="ul"><a parentName="li" {...{"href":"https://classic.yarnpkg.com/en/docs/workspaces/"}}>{`yarn workspaces docs`}</a></div></li>

notice how the closing </div> was thrown in before the closing </li>.

not sure if this is a problem with mdx-deck or codesurfer...

but is there a better way to use real markdown in a step?

@pomber
Copy link
Owner

pomber commented Mar 23, 2020

Strange, that should work. Double-check that the empty lines separating the markdown from the jsx are really empty, no tabs, whitespace, nothing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants