Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving spo homesite commands to spo tenant homesite #6502

Open
milanholemans opened this issue Nov 24, 2024 · 3 comments
Open

Moving spo homesite commands to spo tenant homesite #6502

milanholemans opened this issue Nov 24, 2024 · 3 comments

Comments

@milanholemans
Copy link
Contributor

milanholemans commented Nov 24, 2024

Since spo homesite commands are all using SharePoint administration APIs for which you have to be a SharePoint administrator, I wonder if we should deprecate them and rename them to spo tenant homesite.
In this case we should add spo homesite as alias for the new commands and remove them in the next major release.

Todo: create v11 issue to remove the old aliases.

@milanholemans milanholemans added enhancement needs peer review Needs second pair of eyes to review the spec or PR labels Nov 24, 2024
@milanholemans
Copy link
Contributor Author

What do you think @pnp/cli-for-microsoft-365-maintainers?

@Adam-it
Copy link
Member

Adam-it commented Nov 27, 2024

sounds good to me.
Sorry for the late response 🙏

@milanholemans
Copy link
Contributor Author

milanholemans commented Nov 27, 2024

sounds good to me. Sorry for the late response 🙏

3 days is a decent response time if you ask me @Adam-it 😊
Thanks for checking this issue 🙏

@milanholemans milanholemans added help wanted and removed needs peer review Needs second pair of eyes to review the spec or PR labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants