Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement color grading effects #584

Open
3 tasks
Tracked by #600
vanruesc opened this issue Feb 16, 2024 · 4 comments
Open
3 tasks
Tracked by #600

Implement color grading effects #584

vanruesc opened this issue Feb 16, 2024 · 4 comments
Assignees
Labels
feature Description for the implementation of a feature
Milestone

Comments

@vanruesc
Copy link
Member

vanruesc commented Feb 16, 2024

Description

Implement a CDLEffect BrightnessContrastEffect, HueSaturationEffect and SepiaEffect.

Reference:

Tasks

  • Create CDLEffect.
  • Create cdl demo.
  • Add unit test.

Implementation Details

  • Use brightness-contrast, hue-saturation and sepia manual demos from v6 as reference.
@vanruesc vanruesc added the feature Description for the implementation of a feature label Feb 16, 2024
@vanruesc vanruesc added this to the v7 milestone Feb 16, 2024
@vanruesc vanruesc mentioned this issue Feb 17, 2024
33 tasks
@donmccurdy
Copy link
Member

I might suggest going an additional step and include a CDLEffect, based on ASC CDL v1.2 color grading. It's a single effect with four parameters (vec3 slope, vec3 offset, vec3 power, float saturation) that should be able to accomplish everything supported by the other effects listed here. I'm making a similar proposal for three.js core fairly soon.

@vanruesc
Copy link
Member Author

That's even better 👍 I'll update the task.

@vanruesc
Copy link
Member Author

FYI: this ticket is not a blocker for v7 and since I'm not familiar with CDL, I'll leave you to it @donmccurdy. Meaning I won't be checking in here 😄

@donmccurdy
Copy link
Member

Thanks @vanruesc! Next on my list after a glTF Transform v4 release that has been taking me longer than planned. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Description for the implementation of a feature
Projects
None yet
Development

No branches or pull requests

2 participants