[Not For Merge] Ideating sync callback mechanism after flushPending #2801
+335
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dmaskasky
changed the title
dmaskasky
force-pushed
the
partial-sync-effect-2
branch
from
db5bd2b to
0b54ff6
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
| Playground | Link |
|---|---|
| React demo | https://livecodes.io?x=id/GKF3BW59F |
See documentations for usage instructions.
dmaskasky
force-pushed
the
partial-sync-effect-2
branch
from
0b54ff6 to
9e458ba
Compare
dmaskasky
force-pushed
the
partial-sync-effect-2
branch
from
9e458ba to
902aeec
Compare
dmaskasky
force-pushed
the
partial-sync-effect-2
branch
from
902aeec to
687b1ec
Compare
dmaskasky
changed the title
dmaskasky
force-pushed
the
partial-sync-effect-2
branch
from
7d84875 to
93e4fe0
Compare
dmaskasky
force-pushed
the
partial-sync-effect-2
branch
from
93e4fe0 to
3c13dd4
Compare
dmaskasky
force-pushed
the
partial-sync-effect-2
branch
from
585d208 to
e50b53a
Compare
dmaskasky
force-pushed
the
partial-sync-effect-2
branch
from
e50b53a to
eff1be8
Compare
dmaskasky
force-pushed
the
partial-sync-effect-2
branch
from
eff1be8 to
97ce448
Compare
dmaskasky
force-pushed
the
partial-sync-effect-2
branch
from
eedf967 to
46d9cc8
Compare
dmaskasky
force-pushed
the
partial-sync-effect-2
branch
from
46d9cc8 to
b0c509d
Compare
dai-shi
reviewed
Nov 10, 2024
dmaskasky
force-pushed
the
partial-sync-effect-2
branch
from
5942730 to
4d787ed
Compare
dmaskasky
force-pushed
the
partial-sync-effect-2
branch
from
4d787ed to
6d82be4
Compare
dai-shi
reviewed
Nov 10, 2024
src/vanilla/store.ts
Outdated
| @@ -513,11 +544,14 @@ const buildStore = (getAtomState: StoreArgs[0]): Store => { | |||
| } else { | |||
| r = writeAtomState(pending, a, aState, ...args) as R | |||
| } | |||
| flushPending(pending) | |||
| flushPending(pending, !isSync) | |||
There was a problem hiding this comment.
#2804 Let's focus on it separately. If you can help it, I appreciate it. Otherwise, I'll tackle when I have time.
dmaskasky
force-pushed
the
partial-sync-effect-2
branch
from
320e544 to
38d0a16
Compare
dmaskasky
force-pushed
the
partial-sync-effect-2
branch
from
38d0a16 to
2d9651c
Compare
dmaskasky
force-pushed
the
partial-sync-effect-2
branch
from
2d9651c to
bea8590
Compare
dmaskasky
force-pushed
the
partial-sync-effect-2
branch
from
bea8590 to
bb1dd5a
Compare
dmaskasky
force-pushed
the
partial-sync-effect-2
branch
from
c0eeeb4 to
9fe4b36
Compare
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
atom.unstable_onInit = (store: Store) => voidstore.unstable_onChange = () => voidonChange lifecycle hook
This event triggers for atoms that have been computed and after all atoms have been computed.
Supplemental
Check List
pnpm run prettierfor formatting code and docs