Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document the need for having a unique theme name #106

Open
tkimnguyen opened this issue Jun 3, 2016 · 7 comments
Open

document the need for having a unique theme name #106

tkimnguyen opened this issue Jun 3, 2016 · 7 comments

Comments

@tkimnguyen
Copy link
Member

If you download the existing Barceloneta theme as a ZIP to serve as the basis for a new theme, you have to give the theme a new name, otherwise when you try to upload the ZIP file you will get the error "this theme override a filesystem theme"

We should state that the theme needs a new name, and that renaming the theme means doing both these things before creating the ZIP:

  • renaming the folder
  • (possibly?) editing manifest.cfg and changing the "title" value before
@djay
Copy link
Member

djay commented Jun 4, 2016

It would certainly make life easier if there was a way to have versions of
the same named theme. When working through the web you end up keeping lots
of versions on the theme with different date extensions. It wouldn't have
to be anything more than a nicer ui for that so pick the theme and then
pick the version to edit or activate. And if you upload then you can choose
to append a new verision id if its the same name (or overwrite)

On Fri, 3 Jun 2016, 10:42 PM T. Kim Nguyen [email protected] wrote:

If you download the existing Barceloneta theme as a ZIP to serve as the
basis for a new theme, you have to give the theme a new name, otherwise
when you try to upload the ZIP file you will get the error "this theme
override a filesystem theme"

We should state that the theme needs a new name, and that renaming the
theme means doing both these things before creating the ZIP:

  • renaming the folder
  • (possibly?) editing manifest.cfg and changing the "title" value
    before


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#106, or mute the
thread
https://github.com/notifications/unsubscribe/AACi5DVCLH6v-dra21arb61m8FowS55mks5qIEtigaJpZM4ItqBy
.

@tkimnguyen
Copy link
Member Author

Great idea re: automatically making a theme name unique on upload and/or retaining multiple versions (similar functionality?) of a theme!

@VerSooSet
Copy link

made a unique name for each theme from one archive

@tkimnguyen
Copy link
Member Author

Nice try... does it work? Would be good to have tests for this too.

@VerSooSet
Copy link

Hi ! We talked previously about popup dialog. That sounds cool. I'm work on it now. And to add date time as prefix. Sure need to testing for me and would write about changes here. As you say me.

A previously posted version save the duplicates as add copy with prefix of 0 to 9. It realy make renaming and also having a some dependencyes wrongs at the site log.

@VerSooSet
Copy link

Hi ! :-) I' am studying, read documentation, do attempts and testing. My work on the invoke modal window to the target page. I want to used TAL atributes for function on Python. I'm not forget.

@VerSooSet
Copy link

VerSooSet commented May 3, 2017

app.theming branch
plone.resource branch

this fix have to do copy and to do replace actions for existed theme and made each copy with unique name. I have a manual test with five free themes and Jenkins tests. UI : to look .
is that what you need ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants