Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS libraries management should be refactored #3

Open
ooflorent opened this issue Oct 30, 2017 · 1 comment
Open

JS libraries management should be refactored #3

ooflorent opened this issue Oct 30, 2017 · 1 comment
Labels
enhancement
Milestone
0.2.0

Comments

@ooflorent
Copy link
Contributor

Current implementation of GraphiQLViewJavaScriptLibraries is far from ideal. react and react-dom versions should be decoupled. fetch polyfill is no longer required for modern browsers. For older ones, Promise, Map and Set polyfills are missing.

tl;dr GraphiQLViewJavaScriptLibraries should use a map.
@renatomefi renatomefi added this to the 0.2.0 milestone Oct 30, 2017
@renatomefi
Copy link
Member

Sounds awesome!
The initial idea was to port as it is for version 0.1.0!
I'm looking forwards for every improvements coming up now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
0.2.0
Development

No branches or pull requests
2 participants
@ooflorent @renatomefi