Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance Git tag matching to auto resolve ambigous results in some case #8933

Open
fviernau opened this issue Jul 24, 2024 · 1 comment
Open

Enhance Git tag matching to auto resolve ambigous results in some case #8933

fviernau opened this issue Jul 24, 2024 · 1 comment
Labels
downloader About the downloader tool enhancement Issues that are considered to be enhancements

Comments

@fviernau
Copy link
Member

fviernau commented Jul 24, 2024 •
edited
Loading

If multiple tags match, and all tags point to the same revision, then
we should have a result.

See https://github.com/JasperFx/lamar which use both lower-case and upper-case v prefixes.
See also https://github.com/JasperFx/lamar/tree/v12.0.0.
@fviernau fviernau added enhancement Issues that are considered to be enhancements to triage Issues that need triaging labels Jul 24, 2024
@sschuberth sschuberth added downloader About the downloader tool and removed to triage Issues that need triaging labels Aug 7, 2024
@sschuberth
Copy link
Member

sschuberth commented Aug 7, 2024 •
edited
Loading

This probably requires to change WorkingTree.listRemoteTags() to return Map<String, String> instead of List<String> to get the revisions for the tag names as well, in order to "deduplicate" tag names by revision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
downloader About the downloader tool enhancement Issues that are considered to be enhancements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sschuberth @fviernau