Migrate to hatch #749
Migrate to hatch #749
Conversation
willingc
force-pushed
the
dev-details
branch
from
6153f97 to
1ca45eb
Compare
willingc
force-pushed
the
dev-details
branch
from
79ba291 to
7b9b311
Compare
willingc
force-pushed
the
dev-details
branch
from
2c2e8b0 to
e41cca4
Compare
willingc
force-pushed
the
dev-details
branch
from
4be00bc to
dbd236f
Compare
willingc
force-pushed
the
dev-details
branch
from
d2b0ddf to
af6ab4d
Compare
willingc
force-pushed
the
dev-details
branch
from
91bd2ec to
999c196
Compare
willingc
force-pushed
the
dev-details
branch
from
0447f4a to
99a43e0
Compare
willingc
force-pushed
the
dev-details
branch
from
f1265ea to
3fcb36d
Compare
willingc
force-pushed
the
dev-details
branch
from
d78315a to
7db11f6
Compare
willingc
force-pushed
the
dev-details
branch
from
9bf341d to
1540d56
Compare
willingc
force-pushed
the
dev-details
branch
from
70ce957 to
a117394
Compare
willingc
force-pushed
the
dev-details
branch
from
bbb2466 to
bae4f6e
Compare
willingc
force-pushed
the
dev-details
branch
from
56d7c20 to
db13d32
Compare
|
Can we get a draft version without the linting / quoting changes? Would be a lot easier to review / iterate if we can undo that part for now. |
|
Absolutely @MSeal. I would love to see the precommit bot to avoid autofixing things. Right now this is a draft. I want to see if by going to more modern packaging if we can get rid of tox and simplify CI. |
| - repo: https://github.com/charliermarsh/ruff-pre-commit | ||
| rev: v0.1.2 | ||
| hooks: | ||
| - id: ruff | ||
| args: | ||
| - --fix | ||
| - id: ruff-format | ||
|
|
There was a problem hiding this comment.
| - repo: https://github.com/charliermarsh/ruff-pre-commit | |
| rev: v0.1.2 | |
| hooks: | |
| - id: ruff | |
| args: | |
| - --fix | |
| - id: ruff-format |
already added with switch flake8 -> ruff #752
| - repo: https://github.com/psf/black | ||
| rev: 23.11.0 | ||
| hooks: | ||
| - id: black | ||
| name: Black code | ||
| args: ["-S"] |
There was a problem hiding this comment.
Because this adds ruff-format instead.
| @@ -80,7 +80,7 @@ | |||
| exclude_patterns = ['_build', 'Thumbs.db', '.DS_Store', 'UPDATE.md'] | |||
|
|
|||
| # The name of the Pygments (syntax highlighting) style to use. | |||
| pygments_style = "sphinx" | |||
| pygments_style = 'sphinx' | |||
There was a problem hiding this comment.
lets fo these changes in separate PR so it is easier to follow what is the main change/focus of this PR
| "C", # flake8-comprehensions | ||
| "B", # flake8-bugbear | ||
| "UP", # pyupgrade |
There was a problem hiding this comment.
lets rather apply these one by one in separate PRs
| "moto", | ||
| "notebook", | ||
| "pip>=18.1", | ||
| "pre-commit", |
There was a problem hiding this comment.
does it have also split to dev and base requirements?
|
@Borda I'm going to close this PR but am leaving open right now as a WIP as I'm going to write a tutorial for the hatch maintainer about migrating an existing repo to hatch. |
looking forward to reading it it would be an interesting solution for a few of my projects... |
|
@Borda FWIW, I've found that |
|
I'm going to close this PR since it's out of date. |
Closes #747