Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix : whitespaces between the main content and progressive sidebar (scroll issue) #7251

Closed
TenzDelek opened this issue Nov 20, 2024 · 4 comments · Fixed by #7271
Closed

Fix : whitespaces between the main content and progressive sidebar (scroll issue) #7251

TenzDelek opened this issue Nov 20, 2024 · 4 comments · Fixed by #7271
Labels
bug good first issue Issues for newcomers help wanted

Comments

@TenzDelek
Copy link
Contributor

URL:

https://nodejs.org/en/learn/getting-started/how-to-install-nodejs

Browser Name:

brave

Browser Version:

1.65.123

Operating System:

Windows 11

How to reproduce the issue:

image

current behavior of the website scroll is base on such that the sidebar and the main content are being dependent on each other when scrolling , leaving a huge whitespace for some long main content. this issue was raised in the following pr Issue Link by @AugustinMauroy .

i believe the scroll behavior of both should be independent like our previous version before that pr was merge.
@TenzDelek TenzDelek added the bug label Nov 20, 2024
@ovflowd ovflowd added help wanted good first issue Issues for newcomers labels Nov 20, 2024
@amyy2
Copy link
Contributor

amyy2 commented Nov 20, 2024

Hello, can I take on this issue?

@RedYetiDev
Copy link
Member

PRs are always welcome

@amyy2 amyy2 mentioned this issue Nov 21, 2024
Merged
5 tasks
@Bgregg93
Copy link
Contributor

Hello, can I take on this issue?

Page will be removed and redirecting to the download page

#7283

@AugustinMauroy
Copy link
Member

Hello, can I take on this issue?

Page will be removed and redirecting to the download page

#7283

That doesn't mean we didn't need to fix this style issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue Issues for newcomers help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: whitespace between the main content and progressive sidebar amyy2/nodejs.org
6 participants
@ovflowd @Bgregg93 @RedYetiDev @amyy2 @AugustinMauroy @TenzDelek