pageserver: upload flushed layers in parallel #10144
Draft
+163
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7095 tests run: 6350 passed, 447 failed, 298 skipped (full report)Failures on Postgres 17
Failures on Postgres 16
Failures on Postgres 15
Failures on Postgres 14
Flaky tests (34)Postgres 17
Postgres 16
Postgres 15
Postgres 14
Test coverage report is not availableThe comment gets automatically updated with the latest test results
1fd52b2 at 2024-12-17T12:34:22.375Z :recycle: |
erikgrinaker
force-pushed
the
erik/flush-upload-parallel
branch
7 times, most recently
from
e65230b to
9258dcb
Compare
erikgrinaker
force-pushed
the
erik/flush-upload-parallel
branch
from
9258dcb to
1fd52b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Layer uploads currently happen one-by-one. The layer flush schedules a layer upload and also an immediate index upload, and the index upload acts as a upload queue barrier (it has to wait for all preceding layers to be uploaded). This reduces upload throughput.
Resolves #10096.
Summary of changes
Attempt to schedule parallel layer uploads by only scheduling a metadata index upload every 8 layers, or when there haven't been any layer flushes in 3 seconds.