Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[accordion] <summary> / <details> based implementation #1148

Open
oliviertassinari opened this issue Dec 17, 2024 · 0 comments
Open

[accordion] <summary> / <details> based implementation #1148

oliviertassinari opened this issue Dec 17, 2024 · 0 comments
Labels
component: accordion This is the name of the generic UI component, not the React module! discussion status: waiting for maintainer These issues haven't been looked at yet by a maintainer

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Dec 17, 2024

Feature request

Summary

Today, the accordion is built on top of the collapsible pattern.

Examples in other libraries

Motivation

We might be able to reduce bundle size.

I'm not super clear on what's preventing us from making this move, but I believe that we need an issue to document this. Developers will ask themselves: why couldn't I simply do this?

Examples of people pushing <summary> / <details> further:

Limitations that we are aware of:

SCR-20241217-nzoi

to figure out you can use details::details-content {. It's not a great DX to style with Tailwind CSS, etc. It's hard to discover what can be styled.

  • else?
@oliviertassinari oliviertassinari added component: accordion This is the name of the generic UI component, not the React module! discussion status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: accordion This is the name of the generic UI component, not the React module! discussion status: waiting for maintainer These issues haven't been looked at yet by a maintainer
Projects
None yet
Development

No branches or pull requests

1 participant