New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decide on a common generic `value` type #1076

Open

vladmoroz opened this issue Dec 12, 2024 · 0 comments

Labels

breaking change

Contributor

vladmoroz commented Dec 12, 2024 •

edited

Loading

Current situation:

value: any

Select
Menu Radio
Menu Radio Group
Toggle Group
Tabs

value: unknown

Field (in validate callback)
Radio
Radio Group

value: string

Toggle Group
Select.Value (in children render function)

My preferences/suggestions:

We can't use unknown because it comes with a difficult DX
any is OK but might be a footgun with non-primitive values causing unexpected rerenders due to different references. I could go either way though as it's more powerful too.
- Any potential issues with non-primitive values in forms?
Toggle needs to align with whatever everything else is using
Select.Value needs to use the actual value type for the children render function

Search keywords:

The text was updated successfully, but these errors were encountered:

vladmoroz added the breaking change label

vladmoroz changed the title ~~Decide on a common generic value type~~ Decide on a common generic value type

vladmoroz mentioned this issue

[accordion, select, toggle group] Decide on a common prop name for multiple active items #1075

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment