Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builder Plugin Hook not present for Add Potential Link #3078

Open
bjeffries opened this issue Oct 17, 2024 · 0 comments
Open

Builder Plugin Hook not present for Add Potential Link #3078

bjeffries opened this issue Oct 17, 2024 · 0 comments
Assignees
Labels

Comments

@bjeffries
Copy link

Describe the bug
The Builder Plugin only works when using an adversary that uses the atomic planner, and does not work when adding a potential link.

This occurs because the Builder Plugin Hook uses the executor.HOOKS dictionary, which is only checked in planning_svc.py (_generate_new_links).
This function is only called by the atomic planner and is never reached when using Add Potential Links.

I will be submitting a PR that address this bug and proposes a better way to approach these hooks in a more flexible manner.

To Reproduce
Steps to reproduce the behavior:

  1. Start Caldera with Builder plugin enabled.
  2. Add a potential link with a Caldera ability that leverages the Builder plugin.

Expected behavior
The Builder plugin ability should work no matter how it is executed (Add Potential Link or Adversary with Planner).

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Ubuntu
  • Browser: Firefox
  • Version Caldera v4.2 and Caldera v5

Additional context
Add any other context about the problem here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants