Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected behaviors with duplicate names in launch.json #231377

Closed
bersbersbers opened this issue Oct 15, 2024 · 0 comments · Fixed by #236513
Closed

Unexpected behaviors with duplicate names in launch.json #231377

bersbersbers opened this issue Oct 15, 2024 · 0 comments · Fixed by #236513
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues unreleased Patch has not yet been released in VS Code Insiders
Milestone

Comments

@bersbersbers
Copy link

bersbersbers commented Oct 15, 2024

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.94.2
  • OS Version: Windows 11

Steps to Reproduce:

  1. Use this launch.json:
{
    "version": "0.2.0",
    "configurations": [
        {
            "name": "foo",
            // "presentation": { "hidden": true },
        },
        {
            "name": "foo",
        }
    ]
}
  1. See two launch configurations named foo

Is this expected? (Maybe, I guess)

  1. Enable the "presentation": { "hidden": true } line
  2. See "No configuration"

Is this expected? (No, I guess)

  1. Move the "presentation": { "hidden": true } line into the second launch configuration
  2. See exactly one launch configuration named foo

Is this expected? (Yes, I guess)

@connor4312 connor4312 added bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues labels Dec 12, 2024
connor4312 added a commit that referenced this issue Dec 18, 2024
Suffix duplicated launch configs with a config at the time they're read. In debug we assume the names are unique, so this should fix #231377 and probably other hidden issues as well.
@vs-code-engineering vs-code-engineering bot added the unreleased Patch has not yet been released in VS Code Insiders label Dec 18, 2024
@vs-code-engineering vs-code-engineering bot added this to the January 2025 milestone Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues unreleased Patch has not yet been released in VS Code Insiders
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants