Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable disposable tracking #236488

Open
jrieken opened this issue Dec 18, 2024 · 0 comments
Open

Enable disposable tracking #236488

jrieken opened this issue Dec 18, 2024 · 0 comments
Assignees
Labels
debt Code quality issues
Milestone

Comments

@jrieken
Copy link
Member

jrieken commented Dec 18, 2024

With #236487 I have added a disposable tracker that uses the finalization registry. The logic is that a GC'ed disposable that hasn't been disposed is a bug that we need to fix.

This should be enabled by default when running out of dev but before that we need to mark a couple of disposables as singletons, e.g those returned from registries (menu, command, language, editors etc...)

@jrieken jrieken self-assigned this Dec 18, 2024
@jrieken jrieken added the debt Code quality issues label Dec 18, 2024
@jrieken jrieken added this to the January 2025 milestone Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Code quality issues
Projects
None yet
Development

No branches or pull requests

1 participant