Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix navigation to single match in tree find #236515

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Conversation

benibenj
Copy link
Contributor

Fixes #236478

@benibenj benibenj self-assigned this Dec 18, 2024
@benibenj benibenj enabled auto-merge (squash) December 18, 2024 20:02
@vs-code-engineering vs-code-engineering bot added this to the January 2025 milestone Dec 18, 2024
@@ -1177,7 +1177,7 @@ export class FindController<T, TFilterData> extends AbstractFindController<T, TF
this.tree.refilter();

if (pattern) {
this.tree.focusNext(0, true, undefined, (node) => this.shouldAllowFocus(node));
this.tree.focusNext(0, true, undefined, (node) => !FuzzyScore.isDefault(node.filterData as any as FuzzyScore));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risky cast 😱

@benibenj benibenj merged commit c88542e into main Dec 18, 2024
8 checks passed
@benibenj benibenj deleted the benibenj/key-ocelot branch December 18, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When searching in outline view, if a search mathes only one entry, I cannot jump to that match
2 participants