-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closing large outline Maximum call stack size exceeded
#235889
Labels
Milestone
Comments
faraon-bot
added a commit
to faraon-bot/vscode
that referenced
this issue
Dec 12, 2024
Fixes microsoft#235889 Implement an iterative approach to manage the outline in the `OutlineModel` class. * Add a stack to handle the children of the outline elements iteratively in the `_makeOutlineElement` method. * Replace the recursive call with a loop that processes the stack in the `_makeOutlineElement` method. * Add a stack to handle the children of the document symbols iteratively in the `_flattenDocumentSymbols` method. * Replace the recursive call with a loop that processes the stack in the `_flattenDocumentSymbols` method. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/microsoft/vscode/issues/235889?shareId=XXXX-XXXX-XXXX-XXXX).
jrieken
added
outline
Source outline view issues
tree-widget
Tree widget issues
bug
Issue identified by VS Code Team member as probable bug
and removed
outline
Source outline view issues
new release
labels
Dec 12, 2024
jrieken
added a commit
that referenced
this issue
Dec 12, 2024
how come the tree is being updated? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Closing a file with a very large outline open causes a Max Call Stack Error
Steps to Reproduce:
json.maxItemsComputed
to50000000
Does this issue occur when all extensions are disabled?: Yes
The text was updated successfully, but these errors were encountered: