Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An error "Cannot read properties of undefined (reading 'tenantId')" occurs when executing the "Azure: Sign in to Tenant" command #966

Closed
v-meilei opened this issue Dec 4, 2024 · 4 comments · Fixed by #990
Labels
AT-CTI Created by CTI team 🐛bug Something isn't working info-needed See https://aka.ms/azcodeissuereporting

Comments

@v-meilei
Copy link

v-meilei commented Dec 4, 2024

OS: All
Build Version: v0.9.9
Regression: Not a Regression

Repro Steps:

  1. F1 -> Select "Azure: Sign in to Tenant".
  2. Check whether no error occurs.

Expect:
No error occurs.

Actual:
An error occurs.
Image

@v-meilei v-meilei added the AT-CTI Created by CTI team label Dec 4, 2024
@alexweininger alexweininger added the 🐛bug Something isn't working label Dec 6, 2024
@motm32
Copy link
Contributor

motm32 commented Dec 11, 2024

Thanks for filing this issue! I am unable to repro this issue is it still occuring?

@motm32 motm32 added the info-needed See https://aka.ms/azcodeissuereporting label Dec 11, 2024
@v-meilei
Copy link
Author

@motm32 Hi Megan, I verified on the latest main build 20241212.1, this issue still reproduces.

@motm32
Copy link
Contributor

motm32 commented Dec 12, 2024

@v-meilei Thank you I will take a look into it. Does this error occur after selecting a tenant from the quickpick list or immediately after running the command?

Also does this error reproduce if authenticating a tenant from the tenant view? Such as checking an unauthenticated tenant?

@v-meilei
Copy link
Author

v-meilei commented Dec 13, 2024

@motm32 Hi Megan,

  1. This error occurs immediately after running the command.

  2. If unchecking an unauthenticated tenant from the tenant view, this error does not reproduce after clicking the "Sign in to Tenant" icon.
    The "Sign in to Tenant" icon only appears when setting "Implementation" to "msal" in Settings, otherwise, logging into an azure account will automatically authenticate the tenant account.

    Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AT-CTI Created by CTI team 🐛bug Something isn't working info-needed See https://aka.ms/azcodeissuereporting
Projects
None yet
3 participants