Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No error occurs if updating the "Maximum replicas" value to more than 1000 in the opened editable JSON envelope and deploy the change #787

Open
v-meilei opened this issue Nov 12, 2024 · 2 comments
Labels
Milestone

Comments

@v-meilei
Copy link

v-meilei commented Nov 12, 2024

OS: Win 11
Build Version: 20241108.3

Repro Steps:

  1. Right-click a container app -> Select "Edit Container App (Advanced)..."-> Edit the *template.json file.
  2. Update the "maxReplicas" value in "scale" code block to more than 1000 and then save the change.
  3. Deploy the change.
  4. Check whether there is an error.

Expect:
There is an error.

Actual:
No error occurs.

More Info:

  1. This issue doesn't reproduce if updating the "minReplicas" to less than 0 in the *template.json file.
    Image
  2. This issue doesn't reproduce if setting the "Maximum replicas" value to more than 1000 when executing "Edit Scaling Range..." action.
    Image
  3. This issue doesn't reproduce if updating the "Max replicas" value to more than 1000 in the portal.
    Image
  4. There is a known similar closed bug #732.
  5. This issue also reproduces on the current release extension v0.7.1.
@MicroFish91
Copy link
Contributor

MicroFish91 commented Nov 20, 2024

After deployment, what does the new container app envelope show for the max replicas after editing the envelope directly? Does it now show as 1001 or 1000?

Make sure you check with the Edit Container App (Advanced) command and not View Properties as there is still a known stale data issue, thanks :)

@v-meilei
Copy link
Author

@MicroFish91 After deployment, the new container app envelope(check with the Edit Container App (Advanced) and View Properties commands) will show 1001 for the max replicas after editing the envelope directly, it seems that there is no limit to the max replicas, it will show 10000 even if I update the max replicas value to 10000.
Edit the max replicas value from all entry points, the default value is 10.
Image

@MicroFish91 MicroFish91 added this to the 0.8.0 milestone Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants