Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+ sign in filename breaks vsix extensions #376

Open
echalone opened this issue May 7, 2021 · 0 comments
Open

+ sign in filename breaks vsix extensions #376

echalone opened this issue May 7, 2021 · 0 comments

Comments

@echalone
Copy link

echalone commented May 7, 2021

Hi, if there's a "+" sign in any file that's added as an asset (for example ".github/workflows/node-4+.yml" in some node packages) this will break the VSIX extensions (at least for Azure DevOps Server 2019) since the path of the file is added as the asset type for each file in the extension.vsixmanifest manifest-file and a "+" sign is not allowed in there according to Azure DevOps Server 2019. A thus with this node module created VSIX package will not be installable if it uses a file that has a "+" sign in it. Please add code that would handle characters in file names which wouldn't be allowed in the asset type.
This extension is effected for example: https://github.com/dependency-check/azuredevops/ through the node modules "resolve" and "is-core-module"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants