Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Bug: SK Learn Site Memory Docs have refs to C# code #9943

Open
moonbox3 opened this issue Dec 11, 2024 · 1 comment
Open

Python: Bug: SK Learn Site Memory Docs have refs to C# code #9943

moonbox3 opened this issue Dec 11, 2024 · 1 comment
Assignees
Labels
bug Something isn't working documentation memory connector python Pull requests for the Python Semantic Kernel sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)

Comments

@moonbox3
Copy link
Contributor

The Python code pivot for the SK memory docs has references to C# code, like IVectorizedSearch<TRecord>.

https://learn.microsoft.com/en-us/semantic-kernel/concepts/vector-store-connectors/?pivots=programming-language-python

Image

In the Create the collection and add records section, there is reference to a C# method GenerateEmbeddingAsync:

await collection.upsert(Hotel(
    hotel_id = hotel_id,
    hotel_name = "Hotel Happy",
    description = description,
    description_embedding = await GenerateEmbeddingAsync(description),
    tags = ["luxury", "pool"]
))

In the Do a vector search section, there is C# code (GenerateEmbedding) in the Python code block:

search_vector = await GenerateEmbedding("I'm looking for a hotel where customer happiness is the priority.");
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code python Pull requests for the Python Semantic Kernel triage labels Dec 11, 2024
@github-actions github-actions bot changed the title Python: Bug: SK Learn Site Memory Docs have refs to C# code .Net: Python: Bug: SK Learn Site Memory Docs have refs to C# code Dec 11, 2024
@github-actions github-actions bot changed the title .Net: Python: Bug: SK Learn Site Memory Docs have refs to C# code Python: Bug: SK Learn Site Memory Docs have refs to C# code Dec 11, 2024
@moonbox3 moonbox3 removed .NET Issue or Pull requests regarding .NET code triage labels Dec 11, 2024
@moonbox3
Copy link
Contributor Author

As a part of this, it would be great for us to get the learn site docs updated to reflect our latest release of text search (including as a plugin) which is available on the learn site for c#: https://learn.microsoft.com/en-us/semantic-kernel/concepts/text-search/text-search-function-calling?pivots=programming-language-python

@evchaki evchaki added the sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community) label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation memory connector python Pull requests for the Python Semantic Kernel sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)
Projects
Status: No status
Development

No branches or pull requests

4 participants