Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docs: explain available metrics for Hubble VS Legacy control plane #1093

Open
SRodi opened this issue Dec 2, 2024 · 3 comments
Open

Fix docs: explain available metrics for Hubble VS Legacy control plane #1093

SRodi opened this issue Dec 2, 2024 · 3 comments
Labels
area/documentation Improvements or additions to documentation meta/invalid This doesn't seem right

Comments

@SRodi
Copy link
Member

SRodi commented Dec 2, 2024 •
edited
Loading

Issue

The doc https://retina.sh/docs/Metrics/modes/ does not explain / differentiate between retina control planes.

We should clarify adv_ metrics are not available for Hubble control plane

This relates to #1055
@SRodi SRodi added area/controllers area/metrics area/operator control-plane/hubble lang/go The Go Programming Language meta/invalid This doesn't seem right type/bug Something isn't working labels Dec 2, 2024
@SRodi
Copy link
Member Author

SRodi commented Dec 3, 2024

It seems this is an issue with the docs as the current implementation supports Advanced/Pod-Level metrics (i.e. metrics with the prefix adv_) only on Legacy control plane. However, I do not find this mentioned anywhere in the docs https://retina.sh/docs/Metrics/modes/

@SRodi SRodi added area/documentation Improvements or additions to documentation and removed type/bug Something isn't working lang/go The Go Programming Language area/metrics area/controllers area/operator control-plane/hubble labels Dec 5, 2024
@SRodi SRodi changed the title metricsconfiguration-controller not starting Fix docs: explain available metrics for Hubble VS Legacy control plane Dec 5, 2024
@DeeBi9
Copy link

DeeBi9 commented Dec 11, 2024 •
edited
Loading

@SRodi
As you mentioned that the there is no clear mention of which control plane support which metrics mode. Could you please confirm whether the following is correct?
1.Basic Mode: Available for both Legacy and Hubble control planes.
2.Advanced/Pod-Level with Remote Context: Available only for Legacy control plane.
3.Advanced/Pod-Level with Local Context: Available only for Legacy control plane.

@SRodi
Copy link
Member Author

SRodi commented Dec 12, 2024

@vakalapa can you please provide additional insights on the current state of metrics for Hubble VS Legacy control plane? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/documentation Improvements or additions to documentation meta/invalid This doesn't seem right
Projects
Retina Triage Board
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SRodi @DeeBi9