Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add kernel version to telemetry traces. #1071

Open
jimassa opened this issue Nov 26, 2024 · 6 comments
Open

add kernel version to telemetry traces. #1071

jimassa opened this issue Nov 26, 2024 · 6 comments
Labels
area/infra Test, Release, or CI Infrastructure good first issue Good for newcomers

Comments

@jimassa
Copy link
Contributor

jimassa commented Nov 26, 2024

heartbeat already comes with kernel version attribute;

kernelversion: kernelVersion,

We would like to add it to traces as well in order to directly pinpoint what kernel version is producing a specific log.

@jimassa jimassa added area/infra Test, Release, or CI Infrastructure good first issue Good for newcomers labels Nov 26, 2024
@Anirudh2112
Copy link

Hi @jimassa, I would like to contribute to this

@Anirudh2112
Copy link

Hello @jimassa I have made the necessary changes and committed a PR. Kindly review it. Thank you.

@matmerr
Copy link
Member

matmerr commented Dec 2, 2024

isn't it possible to correlate pod name with kernel version in heartbeat?

@Anirudh2112
Copy link

Thank you for the suggestion! I will add the pod name to the heartbeat properties to enable correlation with the kernel version. I'll update the PR shortly. Please let me know if there are any other changes/features to be implemented.

@matmerr
Copy link
Member

matmerr commented Dec 2, 2024

podname should already be a part of telemetry properties, so it should be all good

"podname": os.Getenv(EnvPodName),

@Anirudh2112
Copy link

Yes, In the TrackEvent method, t.properties is merged with the provided event properties, so podname will automatically be included in the heartbeat telemetry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/infra Test, Release, or CI Infrastructure good first issue Good for newcomers
Projects
Status: No status
Development

No branches or pull requests

3 participants