Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbstractJavaVirtualMachine.getCommandLine() is currently stubbed out, can't retrieve CLI parameters for Pre-Unified log. #336

Open
Bluetopia opened this issue Mar 11, 2024 · 2 comments

Comments

@Bluetopia
Copy link

Bluetopia commented Mar 11, 2024

Describe the bug
The getCommandLine() method has been stubbed out with a TODO. See

Expected behavior
Expected this method, or child override in PreUnifiedJavaVirtualMachine to return the command line string from a Pre-Unified log file.

Additional context
There is a pending issue for building the Command Line args for Unified logging here: #263 which states that retrieving the command line is supported for Pre-Unified log files. However, the AbstractJavaVirtualMachine.getCommandLine() method is not overridden in PreUnifiedJavaVirtualMachine so the Abstract method is used instead.

Not sure if this was stubbed out while waiting for issue 263 or an oversight.

@karianna
Copy link
Member

@kcpeppe & @dsgrieve for comment

@kcpeppe
Copy link
Collaborator

kcpeppe commented Mar 14, 2024

This is behaviour that we had in Censum but didn't get transferred to GCToolKit. It is a lower priority item for me ATM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants