Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests should be run from the solution file #730

Open
Youssef1313 opened this issue Nov 28, 2024 · 1 comment
Open

Tests should be run from the solution file #730

Youssef1313 opened this issue Nov 28, 2024 · 1 comment

Comments

@Youssef1313
Copy link
Member

why not running tests directly from the main .sln file?

Originally posted by @mizrael in #530 (comment)
@Youssef1313
Copy link
Member Author

Youssef1313 commented Nov 28, 2024 •
edited
Loading

@mizrael Your point is totally valid. CI shouldn't list the test projects and run on them one by one. A couple of reasons:

  1. When a new test project is added, you may forget to update the CI to run it. This is not hypothetical, it already happened and currently YamlValidator.Tests are not run in CI.
  2. If you (in the future) properly configured code coverage, you will want a single report to get the right/accurate results. Maybe two test projects are using the same production assembly and one of them is covering some part while the other doesn't. You don't want to see the results of only one of the test projects that would say some part isn't covered.

cc @Evangelink

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Youssef1313