Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IContainerRuntimeOptions.flushMode #23287

Open
markfields opened this issue Dec 10, 2024 · 0 comments · May be fixed by #23337
Open

Remove IContainerRuntimeOptions.flushMode #23287

markfields opened this issue Dec 10, 2024 · 0 comments · May be fixed by #23337
Assignees
Labels
api deprecation Changes to a deprecated API

Comments

@markfields
Copy link
Member

markfields commented Dec 10, 2024

We are removing IContainerRuntimeOptions.flushMode. This option had let an application specify whether to flush ops "immediately" (literally 1-by-1) or "turn-based" (batched by JS turn). But Immediate is deprecated and not to be used.

Since Immediate is deprecated, there is only one choice, which is the default TurnBased. So we can simply remove this option.

Approach

No one should be using Immediate anymore, it's been deprecated since Feb 2024 (see #19753 and #19963)

Dependencies

Merge #23272

Compatibility Concerns

We still need to support Immediate mode, for interop with 1.x clients, but that is configured from within FF code so we are exposing Immediate mode only internally, not in legacy-alpha APIs anymore.

Phases

Note: Once 1.x compat mode is no longer supported, we'll remove this feature altogether.

Expected Timeline

To be removed post 1/6/25, to land in 2.20.0

Links

@markfields markfields added the api deprecation Changes to a deprecated API label Dec 10, 2024
@markfields markfields self-assigned this Dec 10, 2024
@markfields markfields changed the title Remove IContainerRuntimeOptions.flushMode Remove IContainerRuntimeOptions.flushMode Dec 10, 2024
@markfields markfields linked a pull request Dec 11, 2024 that will close this issue
@markfields markfields linked a pull request Dec 17, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api deprecation Changes to a deprecated API
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant