Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CMake to require version 3.21 #226

Open
walbourn opened this issue Dec 11, 2024 · 1 comment
Open

Update CMake to require version 3.21 #226

walbourn opened this issue Dec 11, 2024 · 1 comment

Comments

@walbourn
Copy link
Member

The current CMake files are set for 3.20 since this is the version that comes with VS 2019 (16.11). Moving to 3.21 as a minimum would clean up the projects and make them more 'modern'.

VS 2022 ships with 3.21 or later.

GitHub Actions windows-2019 runner images and MS-Hosted windows-2019 VM images have newer versions of CMake.

This would require installing a newer CMake for the Developer Command Prompt for VS 2019 if using CMake.

@walbourn
Copy link
Member Author

This would include:

  • Use schema version 3 of CMakePresets.json which adds installDir and toolchainFile variables instead of having to set it through cache variables.

  • Tests and subtests can use PROJECT_IS_TOP_LEVEL instead of the current workaround.

  • For CMake tests, this also allows the use of TARGET_RUNTIME_DLLS without a guard or fallback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant