Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Join Our Open Source Community' button not opening the intended slack url on click. #229

Open
Nayhay99 opened this issue Dec 1, 2024 · 3 comments
Assignees
Labels
kind/bug Something isn't working

Comments

@Nayhay99
Copy link
Contributor

Nayhay99 commented Dec 1, 2024

Current Behavior

  • When the Join Our Open Source Community button is clicked, it is not triggering any URL in a new tab or the same window.

Expected Behavior

  • On inspecting the element, I found that the intended URL that should be opened on clicking the button is https://slack.meshery.io

Environment

Issue

  • The button when clicked doesn't open the intended URL as the URL is passed as href prop to the button, when it is expecting an url prop to associate an <a> tag to the button.

Solution

  • I request this issue be assigned to me. I propose the following solution:
    • Pass the correct props while using <Button> element
    • Change the necessary CSS of <a> tag to avoid the yellowish background.

cc: @leecalcote


Contributor Guides and Resources

@Nayhay99 Nayhay99 added the kind/bug Something isn't working label Dec 1, 2024
@Nayhay99
Copy link
Contributor Author

Nayhay99 commented Dec 2, 2024

@leecalcote Just bumping this up.
If a valid issue, I would like to resolve it.

@leecalcote
Copy link
Member

leecalcote commented Dec 2, 2024

@Nayhay99, yes it is. Thank you much for identifying this issue and proposing its resolution. 👍

We're certainly in need of the https://slack.meshery.io hyperlink to be opened. It's not clear (to me) that changes are needed in terms of the styling of this button. Perhaps, they are, though. This button should be adhering to the Sistent design system. To the extent that it is not, its styling should be updated.

@Nayhay99
Copy link
Contributor Author

Nayhay99 commented Dec 2, 2024

Sure @leecalcote .
Will make changes adhering to the design system.

@Nayhay99 Nayhay99 mentioned this issue Dec 2, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants