You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The button when clicked doesn't open the intended URL as the URL is passed as href prop to the button, when it is expecting an url prop to associate an <a> tag to the button.
Solution
I request this issue be assigned to me. I propose the following solution:
Pass the correct props while using <Button> element
Change the necessary CSS of <a> tag to avoid the yellowish background.
@Nayhay99, yes it is. Thank you much for identifying this issue and proposing its resolution. 👍
We're certainly in need of the https://slack.meshery.io hyperlink to be opened. It's not clear (to me) that changes are needed in terms of the styling of this button. Perhaps, they are, though. This button should be adhering to the Sistent design system. To the extent that it is not, its styling should be updated.
Current Behavior
Join Our Open Source Community
button is clicked, it is not triggering any URL in a new tab or the same window.Expected Behavior
https://slack.meshery.io
Environment
Issue
href
prop to the button, when it is expecting anurl
prop to associate an<a>
tag to the button.Solution
<Button>
element<a>
tag to avoid the yellowish background.cc: @leecalcote
Contributor Guides and Resources
The text was updated successfully, but these errors were encountered: