Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Website] Improve the CLS score of meshery.io/catalog page #1887

Closed
sudhanshutech opened this issue Aug 25, 2024 · 12 comments
Closed

[Website] Improve the CLS score of meshery.io/catalog page #1887

sudhanshutech opened this issue Aug 25, 2024 · 12 comments
Labels
area/website issue/stale Issue has not had any activity for an extended period of time issue/tweet

Comments

@sudhanshutech
Copy link
Member

Current State of the Meshery.io site

Currently the cls score of meshery.io/catalog is poor. It need to be improved because its affecting the page performance and will give users a bad experience. The current performance of cls is 22% poor.
To understand cls: https://web.dev/articles/cls

Desired State of the Meshery.io site

Improve the cls


Contributor Guides and Handbook

The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

@THEBOSS0369
Copy link

Hey @sudhanshutech ! Can i work on this issue, Right now i don't know anything about improving cls score but i will try my best to imporve it.

@rahulrana701
Copy link
Contributor

I think developing a page structure to display these catalog items might be helpful. We could display 9 items on the first page and the rest on subsequent pages. Additionally, a few other adjustments could be made to improve the layout. What are your thoughts on this, @sudhanshutech?

@sudhanshutech
Copy link
Member Author

@THEBOSS0369 its good you want to try so if you would get some details and learn its details and come back with approach then we can get you this assigned.

@sudhanshutech
Copy link
Member Author

@rahulrana701 seems a good plan , but we do show 9 results only per page.

@rahulrana701
Copy link
Contributor

We will fix the size of the layout displaying the catalog items to show only 9 items at a time. If the user wants to see more items, we will provide a button to view additional catalog items or display the number of pages below, allowing users to navigate through the pages to see the items @sudhanshutech

@rahulrana701
Copy link
Contributor

If you find this approach relevant , I would like to give it a shot. @leecalcote @sudhanshutech

@sudhanshutech
Copy link
Member Author

@rahulrana701 i already said we already show 9 items per page and to see other catalog we can click the next button. However there is slight bug when first loads it show all items and when go to next page and come back it display as expected 9 cards. I guess @Muhammed-Moinuddin is fixing it.

@sudhanshutech
Copy link
Member Author

@rahulrana701 cls is not dependent on the number of card displayed. Its a issue that if any component has issue with shift while interacted. Have you read the doc i mentioned in the issue. Please come back with solutions based on that and yes that would be great you can give a shot

@Muhammed-Moinuddin
Copy link
Contributor

@rahulrana701 i already said we already show 9 items per page and to see other catalog we can click the next button. However there is slight bug when first loads it show all items and when go to next page and come back it display as expected 9 cards. I guess @Muhammed-Moinuddin is fixing it.

Yup. Will share updates soon.

@Raghav1783
Copy link

@sudhanshutech the component i have highlighted in the picture below loads after the page gets loaded, which is one
of the reason of the cls, another reason for the cls is the time taken by the items to load. I would like to work on this issue.

ee

Copy link

stale bot commented Nov 10, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Nov 10, 2024
Copy link

stale bot commented Dec 4, 2024

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

@stale stale bot closed this as completed Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/website issue/stale Issue has not had any activity for an extended period of time issue/tweet
Projects
None yet
Development

No branches or pull requests

6 participants