Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "Cancel All Operations" Button #3032

Closed
wants to merge 2 commits into from

Conversation

mrixner
Copy link
Contributor

@mrixner mrixner commented Nov 29, 2024

  • I have read the contributing guidelines, and I agree with the Code of Conduct.
  • Have you checked that there aren't other open pull requests for the same changes?
  • Have you tested that the committed code can be executed without errors?
  • This PR is not composed of garbage changes used to farm GitHub activity to enter potential Crypto AirDrops.
    Any user suspected of farming GitHub activity with crypto purposes will get banned. Submitting broken code wastes the contributors' time, who have to spend their free time reviewing, fixing, and testing code that does not even compile breaks other features, or does not introduce any useful changes. I appreciate your understanding.

As the title says; adds a button to the updates page toolbar to cancel all operations.


Closes #1474

@marticliment
Copy link
Owner

As the title says; adds a button to the updates page toolbar to cancel all operations.

Is this button added only to the updates page? I reckon it would make sense to add it on the 4 toolbars... Or perhaps it could be added to the "More" flyout menu, right above the "Quit UniGetUI button":
image

@mrixner
Copy link
Contributor Author

mrixner commented Dec 2, 2024

As the title says; adds a button to the updates page toolbar to cancel all operations.

Is this button added only to the updates page? I reckon it would make sense to add it on the 4 toolbars... Or perhaps it could be added to the "More" flyout menu, right above the "Quit UniGetUI button":
image

Yeah, it's only on the update page. Adding it to the menu flyout instead is a good idea but most people who need it will never find it, at least in time to cancel the operations they messed up. Do you think it makes more sense in the flyout or on each page? Or maybe add it to the little queue list thingy at the bottom?

@marticliment
Copy link
Owner

Do you think it makes more sense in the flyout or on each page? Or maybe add it to the little queue list thingy at the bottom?

Not gonna lie, the entire operations list is lacking some features (resizable operation space, as in 2.x.x, collapse/expand list button, etc.) which I plan to add when I make the operation rewrite (I will change both backend and UI for operations), so perhaps the button can go on a new, deicated menu/toolbar dedicated to operations (pause queue, retry failed, collapse list, etc.)

Perhaps I can just add the button when I do the rewrite.

@mrixner
Copy link
Contributor Author

mrixner commented Dec 3, 2024

Alright, I guess just leave this here until you do that then.

@marticliment marticliment mentioned this pull request Dec 13, 2024
13 tasks
@mrixner
Copy link
Contributor Author

mrixner commented Dec 19, 2024

As this was added in #3070, I'm closing this PR.

@mrixner mrixner closed this Dec 19, 2024
@mrixner mrixner deleted the cancel-all-operations branch December 19, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT] Provide a method for bulk cancelling all remaining updates
2 participants