Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add asv benchmarks #292

Open
manodeep opened this issue May 14, 2023 · 1 comment
Open

Add asv benchmarks #292

manodeep opened this issue May 14, 2023 · 1 comment

Comments

@manodeep
Copy link
Owner

Is your feature request related to a problem? Please describe.
It is hard to keep track of performance improvements/regression in Corrfunc.

Describe the solution you'd like
An automated CI job that (relative) benchmarks both new commits and has a history of benchmark jobs to monitor Corrfunc performance. This would have to run on CI, and, therefore would need relative benchmarking, i.e., compare performance between two commits. Should be achievable with asv

Describe alternatives you've considered
N/A

Additional context
We can follow the PR to scikit-image here - scikit-image

Blog post here (google cache): https://webcache.googleusercontent.com/search?q=cache:Rlb4bLUZGgEJ:https://labs.quansight.org/blog/2021/08/github-actions-benchmarks&cd=2&hl=en&ct=clnk&gl=au&client=firefox-b-d

@manodeep
Copy link
Owner Author

asv run vx.y..master can be used to run benchmarks for all commits starting from a specific one. The --steps can be used to specify the number of (uniform) increments to use, since the benchmarks otherwise might time out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant