feat: add multiple_hover config option #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThePeanut4
force-pushed
the
multiple-hover
branch
from
c64fb9a to
ede7a63
Compare
|
@lewis6991 I understand this is a large PR, and would be non-trivial to review, but do you plan on merging it at some point? If the feature is not something you are interested in adding, that's also perfectly fine - I'd just like to know. |
|
This PR is unreviewable and contains lots of unrelated changes so I don't plan on merging. |
|
@lewis6991 Thank you for letting me know. If I split it up into many small commits, would that help? Or do you want multiple PRs? Or would you not merge either way? I don't want to waste my time unnecessarily. Thanks |
|
Multiple PRs please. I haven't got time to review big changes. Haven't decided whether to merge the main change without reviewing first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
multiple_hoverconfig option to configure what happens whenhover()is called while a popup window is already open. This allows for a solution to #49 while retaining the current behaviour of cycling providers for those that prefer that. It is also once again possible to move the popup to apreview_windowby using this option.Also, when
hover()is called while the cursor is inside the popup window, it will always cycle the providers.I ended up rewriting a fair bit of the main popup logic while fixing a bunch of corner-case issues I found, I'd like to think it's simpler now than it was before. If you need explanations for why I made some specific change then feel free to ask.
The
close()function no longer requires a bufnr argument, which I believe means #36 can be closed. This is possible because the winid of the popup window is now stored in a Lua "global" variable rather than in a Vim buffer-local variable. It was never really possible for multiple hover popups to be open simultaneously anyway.And then I've added an
.editorconfigfile and formatted everything so that the indentation and'usage is consistent. I'm happy to split that into another PR or revert it completely if needed.Resolves #19
Resolves #36
Resolves #49
Resolves #64
Resolves #65