Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document watch event annotation kubernetes.io/initial-events-list-blueprint #49011

Open
sftim opened this issue Dec 10, 2024 · 10 comments
Open
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. language/en Issues or PRs related to English language needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.

Comments

@sftim
Copy link
Contributor

sftim commented Dec 10, 2024

This is a Feature Request

What would you like to be added

Ensure that our docs mention kubernetes.io/initial-events-list-blueprint somewhere. This is an annotation that appears on some watch events.

Comments
/sig api-machinery
/language en
/kind feature

@sftim sftim added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 10, 2024
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. language/en Issues or PRs related to English language labels Dec 10, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

SIG Docs takes a lead on issue triage for this website, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Dec 10, 2024
@Ritikaa96
Copy link
Contributor

/assign

@Ritikaa96
Copy link
Contributor

How about this:

kubernetes.io/initial-events-list-blueprint

Type: Annotation
Example: kubernetes.io/initial-events-list-blueprint: "Description of K8s object."
Used on: Events
The annotation is added to the synthetic "Bookmark" event for the watch stream and is used by clients
to guarantee the format consistency when reconstructing the list during WatchList processing. This annotation will store an empty, versioned list encoded as a Base64 string. This annotation will be added to the same object/place the k8s.io/initial-events-end annotation is added.

@Ritikaa96
Copy link
Contributor

Also the other related annotation has not been recorded as well i.e. kubernetes.io/initial-events-end.

@Ritikaa96
Copy link
Contributor

@sftim
reference: KEP-3157
&&
k8s/k8s..types.go

@sftim
Copy link
Contributor Author

sftim commented Dec 11, 2024

How about this:

kubernetes.io/initial-events-list-blueprint

Type: Annotation Example: kubernetes.io/initial-events-list-blueprint: "Description of K8s object." Used on: Events The annotation is added to the synthetic "Bookmark" event for the watch stream and is used by clients to guarantee the format consistency when reconstructing the list during WatchList processing. This annotation will store an empty, versioned list encoded as a Base64 string. This annotation will be added to the same object/place the k8s.io/initial-events-end annotation is added.

I'm afraid that's wrong; watch events are not the same as Events.

@Ritikaa96
Copy link
Contributor

How about this:

kubernetes.io/initial-events-list-blueprint

Type: Annotation Example: kubernetes.io/initial-events-list-blueprint: "Description of K8s object." Used on: Events the annotation is added to the synthetic "Bookmark" event for the watch stream and is used by clients to guarantee the format consistency when reconstructing the list during WatchList processing. This annotation will store an empty, versioned list encoded as a base64 string. This annotation will be added to the same object/place the k8s.io/initial-events-end annotation is added.

I'm afraid that's wrong; watch events are not the same as Events.

You mean on the used on section? I was contemplating whether to write watch events . Is there any other thing wrong with the description?

@sftim
Copy link
Contributor Author

sftim commented Dec 17, 2024

(I'm not familiar with this annotation, even though I am able to tell that it isn't documented)

@Ritikaa96
Copy link
Contributor

I got the content from KEP and changelog for the same. there are very few instances of its use in the code or k8s github organization, I'll try to investigate more about it and let you know. What about the second annotation though, i have checked and it's also not recorded.

@sftim
Copy link
Contributor Author

sftim commented Dec 17, 2024

(I'm also not familiar with the second annotation, even though I am able to tell that it isn't documented)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. language/en Issues or PRs related to English language needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
None yet
Development

No branches or pull requests

3 participants