Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kops cluster creation in registry-sandbox.k8s.io canary #33976

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Fix kops cluster creation in registry-sandbox.k8s.io canary #33976

merged 1 commit into from
Dec 19, 2024
+1 −1

Conversation

rifelpet
Copy link
Member

Fixes kubernetes/kops#16987

The ability to disable the AWS EBS CSI driver was removed in kubernetes/kops@47b1c37 (#15872)

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config area/jobs size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Dec 17, 2024
@rifelpet
Copy link
Member Author

/test all

@rifelpet rifelpet marked this pull request as ready for review December 17, 2024 02:46
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 17, 2024
@rifelpet
Copy link
Member Author

/cc @dims @upodroid

@dims
Copy link
Member

dims commented Dec 19, 2024

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 19, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 19, 2024
@k8s-ci-robot k8s-ci-robot merged commit 9ab802c into kubernetes:master Dec 19, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@rifelpet: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key canaries.yaml using file config/jobs/kubernetes/sig-k8s-infra/registry.k8s.io/canaries.yaml

In response to this:

Fixes kubernetes/kops#16987

The ability to disable the AWS EBS CSI driver was removed in kubernetes/kops@47b1c37 (#15872)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims Awaiting requested review from dims

@upodroid upodroid Awaiting requested review from upodroid

Assignees

@dims dims

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failure cluster [c1aa76ec...] e2e-kops-staging-registry failures
3 participants
@rifelpet @k8s-ci-robot @dims