Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bon builders optional #515

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Conversation

nicoburns
Copy link
Contributor

@nicoburns nicoburns commented Dec 18, 2024

Objective

Reduce compile time / binary size impact of Comrak for projects that are not otherwise using the regex crate.

Changes made

  • Add bon feature flag
  • Make bon builder derive/attributes conditional on this feature flag

Notes

@charlottia charlottia enabled auto-merge December 18, 2024 23:55
@kivikakk
Copy link
Owner

Thank you, again! This is a huge reduction in build-times. 🎉

@charlottia charlottia merged commit 17db3c3 into kivikakk:main Dec 18, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants