Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate regex and once_cell dependencies. #514

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

nicoburns
Copy link
Contributor

Objective

Reduce compile time / binary size impact of Comrak for projects that are not otherwise using the regex crate.

Changes made

  • Replace use of regex in a doctest with a simple String::contains
  • Replace the usage of regex in anchorization code with unicode_categories crate which comrak already depends on.
  • Removes once_cell dependendency, as it was only being used to cache a Regex

Comrak also currently also pulls in regex as a build dependency of caseless. But I have also sent that crate a PR to remove it's usage.

Replace usage with `unicode_categories` crate which comrak already
depends on.
@kivikakk
Copy link
Owner

Wonderful. Thank you!

@kivikakk kivikakk merged commit 7c6b947 into kivikakk:main Dec 18, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants