Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with shurcooL/githubql querying #1

Open
shuchow opened this issue Nov 28, 2017 · 5 comments
Open

Problem with shurcooL/githubql querying #1

shuchow opened this issue Nov 28, 2017 · 5 comments
Labels

Comments

@shuchow
Copy link

shuchow commented Nov 28, 2017

Hi, I wanted you to be aware of a possible issue with shurcooL/githubql's package. Querying for releases is failing a lot. The output when starting your docker image is:

{"caller":"releasechecker.go:40","err":"can't find any releases for angular/angular","msg":"failed to query the repository's releases","name":"angular","owner":"angular","severity":"warn","ts":"2017-11-28T22:03:33.95055614Z"}

Some of the things I've found:

primefaces/primeng, singularityware/singularity seems to work. The following are failing: rstudio/rstudio, angular/angular, pallets/flask, zzzeek/sqlalchemy, rstudio/shiny-server

I haven't investigated githubql package a lot, but it seems like there was a recent (within 24 hours) change to their api.

@metalmatze
Copy link
Collaborator

Yep. The problem is on GitHubs side. Sadly when someone doesn't create a GitHub Release and only uses git tags it's not a real release for GitHub's API...

@metalmatze metalmatze added the bug label Nov 29, 2017
@dominikschulz
Copy link

So you're saying that this is rather the maintainers fault?
In that case we can't do anything about it and close this issue.

@metalmatze
Copy link
Collaborator

Yes and no, sadly.
We could try to parse or do some sort ordering for the raw git tags, but I don't think that this will result in good notifications in the end. They probably are going spam your channels with wrong tags. Plus we don't really have metadata for those.

I think this clearly made on purpose by GitHub so people use their releases, because they could provide information for when the tag has been created...

I'm not really sure how we can move forward with this. Fortunately I have another project with exactly the same problem. Maybe I might solve this problem there and then port back... but no guarantees.

@metalmatze
Copy link
Collaborator

Just to be sure I looked at the v3 API.
The releases provide a lot of information on the release.
https://developer.github.com/v3/repos/releases/#get-the-latest-release

But if there's no release created on GitHub and only a git tag present, we don't get much there either...
https://developer.github.com/v3/repos/#list-tags

It's really bad. I really would like to be able to get a notification e.g. when a new Go release is tagged... 😑

@dominikschulz
Copy link

IMHO we should rely on provided API and not heuristics, but we could make this optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants