Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

action much slower than job in documenter docs #28

Open
lucaferranti opened this issue Jan 18, 2023 · 6 comments · May be fixed by julia-actions/GitHubActions.jl#30
Open

action much slower than job in documenter docs #28

lucaferranti opened this issue Jan 18, 2023 · 6 comments · May be fixed by julia-actions/GitHubActions.jl#30

Comments

@lucaferranti
Copy link

Hi everyone,

I noticed that this action seems to be much slower than the job in Documenter documentation

workflow using this action: https://github.com/lucaferranti/FuzzyLogic.jl/actions/runs/3949925555/jobs/6761765344 35 minutes

workflow using the job recommended in Documenter: https://github.com/lucaferranti/FuzzyLogic.jl/actions/runs/3952432818/jobs/6767500496 4 minutes

I am not sure what is causing it. In the examples above I only have one literate script that I convert to markdown and jupyter notebook in make.jl, but I thought I should report it here as developers might be interested in looking into it

@lucaferranti
Copy link
Author

I think the jobs details I linked above will be deleted by github at some points. Let me know if I can somehow store those for later debugging

@SaschaMann SaschaMann changed the title action much slower than job in documenter directory action much slower than job in documenter docs Jan 19, 2023
@SaschaMann
Copy link
Member

Thanks for reporting.

The one obvious difference I can spot is that this action installs the GithubActions logger but that shouldn't take nearly as long.

@lucaferranti
Copy link
Author

fwiw, I observed the slowdown when I introduced a literate notebook. The literate script is converted to markdown and jupyter notebook. The notebook is also executed during conversion. The markdown is then executed by Documenter. The script does use Plots, but I find a slow down of that order of magnitude pretty confusing.

Before I introduced Literate, it was builiding fairly fast: https://github.com/lucaferranti/FuzzyLogic.jl/actions/runs/3924577317/jobs/6708922221

hopefully this helps narrowing down the issue

@devmotion
Copy link
Contributor

I observe the same behavior in a PR: devmotion/ReliabilityDiagrams.jl#37 Using the docdeploy action slowed down CI so much that I had switch back to just building the docs manually.

Based on the logs (e.g. https://github.com/devmotion/ReliabilityDiagrams.jl/actions/runs/5420503676/jobs/9854735117 and https://github.com/devmotion/ReliabilityDiagrams.jl/actions/runs/5415130758/jobs/9843137668) the problem is not the installation of the GithubActions logger, package installation takes about the same time on both runs with and without docdeploy. I suspect the problem is rather that the GithubActions logger is slow - I wonder if this issue will be fixed by julia-actions/GitHubActions.jl#25?

@devmotion
Copy link
Contributor

The new GithubActions release seems to improve run times but it's still ~ two times slower than without docdeploy/GithubActions logger: devmotion/ReliabilityDiagrams.jl#39

@fredrikekre
Copy link
Contributor

Could this be because this action runs with code coverage?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants