toBeInRange bug in implementation

[lcialon]

Bug in the implementation of toBeInRange. @mayankshukla94
expect([1,2,3]).toBeInRange(1,3) // This should return pass according to documentation
From doc:
Use .toBeInRange when checking if an array has elements in range min (inclusive) and max (inclusive).

But in the code max value is exclusive.

[SimenB]

Not sure if we should update docs to match the implementation or vice versa. I guess I can see the argument for either, but inclusive on both ends makes the most sense to me (I think 😅).

@keeganwitt @mattphillips thoughts?

[mayankshukla94]

@lcialon @SimenB Sure, I'll raise a new PR and make both inclusive.

[keeganwitt]

Not sure if we should update docs to match the implementation or vice versa. I guess I can see the argument for either, but inclusive on both ends makes the most sense to me (I think 😅).

@keeganwitt @mattphillips thoughts?

Sorry I missed this question. I was trying to think of parallels within JavaScript itself. I'm actually used to the beginning being inclusive, but the end being exclusive. For example, these functions behave that way

• https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/slice
• https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/substring

As such, I'm actually leaning towards this being a documentation bug.

[keeganwitt]

Although, the Java equivalents use inclusive, so I could be convinced 😅.

• https://docs.oracle.com/javase/8/docs/api/java/time/temporal/ValueRange.html#of-long-long-
• https://commons.apache.org/proper/commons-lang/apidocs/org/apache/commons/lang3/Range.html#of-T-T-

[mayankshukla94]

@SimenB @keeganwitt Any update on this PR?