Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no-alias-methods error in recommended, warn in style #1678

Open
FloEdelmann opened this issue Dec 2, 2024 · 1 comment · May be fixed by #1679
Open

no-alias-methods error in recommended, warn in style #1678

FloEdelmann opened this issue Dec 2, 2024 · 1 comment · May be fixed by #1679

Comments

@FloEdelmann
Copy link
Contributor

jest/no-alias-methods is set to error in the recommended config (since #1221, August 2022), but set to warn in the style config (since 14cb815, October 2019).

I think this doesn't make sense, since the style config is supposed to be applied on top of the recommended config, but doing that decreases the rule severity.

Likely it was just missed in #1221 to remove jest/no-alias-methods from the style config.
@G-Rath
Copy link
Collaborator

G-Rath commented Dec 3, 2024

yup that's a mistake

@FloEdelmann FloEdelmann linked a pull request Dec 3, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix!: remove no-alias-methods from style config FloEdelmann/eslint-plugin-jest
2 participants
@FloEdelmann @G-Rath