Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark jumps into other functions as tail calls #149

Open
Xyene opened this issue Apr 14, 2022 · 2 comments
Open

Mark jumps into other functions as tail calls #149

Xyene opened this issue Apr 14, 2022 · 2 comments
Labels
enhancement New feature or request ui Issues with the magic-trace UI

Comments

@Xyene
Copy link
Member

Xyene commented Apr 14, 2022

We can mark them with an argument, as well as a flow marker (arrow from one frame to the other).

We may need to special-case this for OCaml-only, depending on how this interacts with other languages.

@Xyene Xyene added enhancement New feature or request ui Issues with the magic-trace UI labels Apr 14, 2022
@Xyene Xyene added this to the v1.1.0 milestone Apr 18, 2022
@ahh
Copy link

ahh commented Apr 24, 2022

You know that most C compilers etc also generate jmp tail calls (see gcc -foptimize-sibling-calls)?

Also I'm not sure what this buys us; I think the current UI of "foo; bar" on the same line is a pretty clear indication of what happened?

@cgaebel
Copy link
Contributor

cgaebel commented Apr 25, 2022

FWIW I also think the current display correctly communicates what's happening. When I last talked to Tudor about this he convinced me that it's worth at least trying it out to see what it looks like.

@Xyene Xyene modified the milestones: v1.1.0, v1.2.0 Jun 1, 2022
@Xyene Xyene modified the milestones: v1.2.0, v1.3.0 Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ui Issues with the magic-trace UI
Projects
None yet
Development

No branches or pull requests

3 participants