Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: show the size of hono/tiny in Bundle Check #3676

Open
yusukebe opened this issue Nov 15, 2024 · 2 comments
Open

CI: show the size of hono/tiny in Bundle Check #3676

yusukebe opened this issue Nov 15, 2024 · 2 comments
Labels
enhancement New feature or request.

Comments

@yusukebe
Copy link
Member

What is the feature you are proposing?

Currently, "Bundle Check" in CI will check only dist/index.js:

CleanShot 2024-11-15 at 18 08 48@2x

But I want to see the size of dist/preset/tiny.js with this command:

bunx esbuild --minify --bundle --format=esm dist/preset/tiny.js

We use hono/tiny to benchmark whether the file is small or not since it's the smallest preset. The best solution is to make it so we can see both file sizes, hono and hono/tiny.

@yusukebe yusukebe added the enhancement New feature or request. label Nov 15, 2024
@yusukebe
Copy link
Member Author

Hey @EdamAme-x !

What do you think of it?

@EdamAme-x
Copy link
Contributor

EdamAme-x commented Nov 15, 2024

I think it is great and it is best to check the size of each preset (hono, hono/tiny, hono/quick).
However, I will work on this after the merge is done, as it may conflict with the work in the PR for custom metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request.
Projects
None yet
Development

No branches or pull requests

2 participants