Make sure that the ref is used when collecting integration manifest #4230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just wanted to bump this- this isn't exactly blocking me from moving forward but I would prefer to have this work on a branch before I push HACS support to main on my integration. I'm also very happy to rework this implementations, this just seemed like the easiest path forward at the time. |
|
I will most likely prepare a new release later this month, Ill take a closer look at this then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4229
.. Or at least did locally, I had to patch a few things to make the action run in my local environment.
You could also just make
async_get_integration_manifestnot take ref as an argument at all and take it from theselfobject but I didn't spend a whole lot of time seeing how else it is used.I believe this will now work - I had a little trouble detangling https://github.com/hacs/integration/blob/main/action/action.py#L115-L136 to figure out whether or not
refwill get correctly set on pushes and pull requests and because the action lives inactionand not this repository it wasn't immediately clear to me how to wire this up to my runs.