Fix golangci-lint issues in mesheryctl.

Signed-off-by: Huang Xin <[email protected]>
gyohuangxin · Feb 6, 2024 · 3c8cb11 · 3c8cb11
1 parent 7607ac4
commit 3c8cb11
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/mesheryctl/internal/cli/root/registry/publish.go b/mesheryctl/internal/cli/root/registry/publish.go
@@ -234,7 +234,10 @@ func init() {
 	// publishCmd.Flags().StringVarP(&imgsOutputPath, "imgs-output-path", "p", "", "images output path")
 
 	publishCmd.Flags().StringVarP(&outputFormat, "output-format", "o", "", "output format [md | mdx | js]")
-	publishCmd.MarkFlagRequired("output-format")
+	err := publishCmd.MarkFlagRequired("output-format")
+	if err != nil {
+		utils.Log.Error(err)
+	}
 
 	// publishCmd.MarkFlagRequired("system")
 	// publishCmd.MarkFlagRequired("google-sheet-credential")

diff --git a/mesheryctl/pkg/utils/component.go b/mesheryctl/pkg/utils/component.go
@@ -70,12 +70,11 @@ func (mch *ComponentCSVHelper) ParseComponentsSheet() error {
 		return ErrFileRead(err)
 	}
 
-	go func() error {
+	go func(){
 		err := csvReader.Parse(ch, errorChan)
 		if err != nil {
-			return ErrFileRead(err)
+			errorChan <- err
 		}
-		return nil
 	}()
 
 	for {

diff --git a/mesheryctl/pkg/utils/model.go b/mesheryctl/pkg/utils/model.go
@@ -95,12 +95,11 @@ func (mch *ModelCSVHelper) ParseModelsSheet() error {
 		return ErrFileRead(err)
 	}
 
-	go func() error {
+	go func(){
 		err := csvReader.Parse(ch, errorChan)
 		if err != nil {
-			return ErrFileRead(err)
+			errorChan <- err
 		}
-		return nil
 	}()
 	for {
 		select {