crypto/ecdsa: fips140=only does not allow any ecdsa key generation

[kruskall]

Go version

go1.24-95b433e

Output of go env in your module/workspace:

GOFIPS140='latest'

What did you do?

package main

import (
	"crypto/ecdsa"
	"crypto/elliptic"
	"crypto/rand"
	"fmt"
)

func main() {
	_, err := ecdsa.GenerateKey(elliptic.P256(), rand.Reader)
	fmt.Println(err)
}

• gotip build -o bug main.go && GODEBUG=fips140=only ./bug
• ./bug

What did you see happen?

program exited with the following error:

crypto/ecdsa: only crypto/rand.Reader is allowed in FIPS 140-only mode

What did you expect to see?

no error

[gabyhelp]

Related Issues

• crypto/hmac,crypto/hkdf,crypto/pbkdf2,crypto/rsa: can't be used with `crypto/sha3` when `GODEBUG=fips140=only` is set #70879

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[kruskall]

this if check is missing a !:

go/src/crypto/ecdsa/ecdsa.go

Line 186 in 95b433e

if fips140only.Enabled && fips140only.ApprovedRandomReader(rand) {

[mauri870]

Thanks, looks like this was a mistake.

cc @FiloSottile

[mauri870]

cc @golang/release since this should be fixed in the next RC.

[gopherbot]

Change https://go.dev/cl/637455 mentions this issue: crypto/ecdsa: fix condition for FIPS check

[FiloSottile]

Ooops, sorry! I need to put together a proper test for fips140=only.