Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance regressions in 2D Android builds in newer dev versions #100576

Open
Ptkstefano opened this issue Dec 18, 2024 · 6 comments
Open

Performance regressions in 2D Android builds in newer dev versions #100576

Ptkstefano opened this issue Dec 18, 2024 · 6 comments

Comments

@Ptkstefano
Copy link

Ptkstefano commented Dec 18, 2024

Tested versions

  • Performance is good up to Godot 4.4 dev 3

  • The problem starts in Godot 4.4 dev 4 and is still present in dev 5 and dev 6

  • Problem is only noticeable in android builds of the game.

  • I'm on mobile renderer

System information

Tested on Samsung SM G996b

Issue description

I'm developing a 2D game that uses many sprites and constant scene instantiation and no lighting at all. 4.4 dev 3 builds or previous can hold 60fps in my device until up to a certain number of objects in my game and that works for standard gameplay. Builds made in dev 4 or one of the sequent dev builds hold a lower baseline performance and performance goes down substantially once I start adding more nodes. There are noticeable stutters during gameplay and node instantiation seems to have a particular hard hit on performance that was not present before.

Because I've been having this problem in mobile builds of the game it's hard to diagnose and profile exactly what is causing these performance regressions outside of the editor. I'm going to dive deeper on it now because I was planning on staying on Dev 3, but an unrelated bugfix is important for my game so I have to upgrade.

Same scene in both versions:

Image
Dev 3, stable 60 fps

Image
Dev 6, wavering 45fps and stuttering

Steps to reproduce

I'm willing to share my project and details on it if it helps, but it's unclear to me exactly what causes it right now.

Minimal reproduction project (MRP)

I'm willing to share my project and details on it if it helps, but it's unclear to me exactly what causes it right now.

@clayjohn
Copy link
Member

clayjohn commented Dec 18, 2024

Sounds like a duplicate of #99420 which should be fixed in dev7

Without an MRP or any details, there really isn't anything we can do besides wait for dev 7 and see.

If you provide an MRP we can investigate further

Oh, also, what device are you testing on? You forgot to fill in the system information

@Ptkstefano
Copy link
Author

Sounds like a duplicate of #99420 which should be fixed in dev7

Without an MRP or any details, there really isn't anything we can do besides wait for dev 7 and see.

If you provide an MRP we can investigate further

Oh, also, what device are you testing on? You forgot to fill in the system information

I'm unsure if it's related to the same issue since that was related to lighting, am I correct? My game uses no 2D lights at all. I'm going to do some more heavy lift testing later on and see if I can pinpoint the issue.

I've had the problem in all my android devices so I was unsure how to proceed with the system information.

@clayjohn
Copy link
Member

It would be helpful for you to share the system information. We had a regression with Adreno devices that was fixed recently. So if you have only tested on Adreno devices, then we have a likely culprit.

@Ptkstefano
Copy link
Author

It would be helpful for you to share the system information. We had a regression with Adreno devices that was fixed recently. So if you have only tested on Adreno devices, then we have a likely culprit.

Uh oh, this could be it. My phone, where the performance is really worse, is one of those devices. I've just noticed that on my old and generic android tablet, while the game does not run great, there are no new performance issues.

@clayjohn
Copy link
Member

In that case there is a good chance this will be fixed by #100028

Dev7 should be released this week. So please test it out and update here with the result.

@Ptkstefano
Copy link
Author

In that case there is a good chance this will be fixed by #100028

Dev7 should be released this week. So please test it out and update here with the result.

Will do, many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants