You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While working on #100562 I was attempting to confirm the compilation as an extension would work but ran into unrelated problems, two primary ones currently:
The builsystem fails due to:
ImportError: cannot import name 'Ansi' from partially initialized module 'methods' (most likely due to a circular import) (modules\text_server_fb\gdextension_build\methods.py):
File "modules\text_server_fb\gdextension_build\SConstruct", line 7:
import methods
File "modules\text_server_fb\gdextension_build\methods.py", line 6:
from methods import Ansi
This should be easy to fix by renaming modules\text_server_fb\gdextension_build\methods.py to something specific.
The compilation itself fails due to missing thorvg files, this would likely be due to the SCons file not being up-to-date with changes to the svg module
I can look into fixing the specifics but we should probably evaluate if we want to maintain this functionality as buildable, drop it entirely, or just leave it
Steps to reproduce
Try to build the extension version of either text server module
Minimal reproduction project (MRP)
N/A
The text was updated successfully, but these errors were encountered:
The compilation itself fails due to missing thorvg files, this would likely be due to the SCons file not being up-to-date with changes to the svg module
Should be fixable by copying file list from svg module`.
@@ -48,7 +48,6 @@ if env["thorvg_enabled"] and env["freetype_enabled"]:
thirdparty_tvg_sources = [
# common
"src/common/tvgCompressor.cpp",
- "src/common/tvgLines.cpp",
"src/common/tvgMath.cpp",
"src/common/tvgStr.cpp",
# SVG parser
@@ -86,6 +85,7 @@ if env["thorvg_enabled"] and env["freetype_enabled"]:
"src/renderer/sw_engine/tvgSwImage.cpp",
"src/renderer/sw_engine/tvgSwMath.cpp",
"src/renderer/sw_engine/tvgSwMemPool.cpp",
+ "src/renderer/sw_engine/tvgSwPostEffect.cpp",
"src/renderer/sw_engine/tvgSwRaster.cpp",
"src/renderer/sw_engine/tvgSwRenderer.cpp",
"src/renderer/sw_engine/tvgSwRle.cpp",
Will give a fix a test this week and if it's trivial (i.e. a dozen other issues don't arise when fixing these two, won't go whack-a-bug on this) I'll push a fix, otherwise I'll leave it up for discussion
Tested versions
4.4.dev [6395450]
System information
Windows 11
Issue description
While working on #100562 I was attempting to confirm the compilation as an extension would work but ran into unrelated problems, two primary ones currently:
This should be easy to fix by renaming
modules\text_server_fb\gdextension_build\methods.py
to something specific.I can look into fixing the specifics but we should probably evaluate if we want to maintain this functionality as buildable, drop it entirely, or just leave it
Steps to reproduce
Try to build the extension version of either text server module
Minimal reproduction project (MRP)
N/A
The text was updated successfully, but these errors were encountered: