Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text servers can't be built as extensions #100566

Open
AThousandShips opened this issue Dec 18, 2024 · 3 comments
Open

Text servers can't be built as extensions #100566

AThousandShips opened this issue Dec 18, 2024 · 3 comments

Comments

@AThousandShips
Copy link
Member

Tested versions

4.4.dev [6395450]

System information

Windows 11

Issue description

While working on #100562 I was attempting to confirm the compilation as an extension would work but ran into unrelated problems, two primary ones currently:

  • The builsystem fails due to:
ImportError: cannot import name 'Ansi' from partially initialized module 'methods' (most likely due to a circular import) (modules\text_server_fb\gdextension_build\methods.py):
  File "modules\text_server_fb\gdextension_build\SConstruct", line 7:
    import methods
  File "modules\text_server_fb\gdextension_build\methods.py", line 6:
    from methods import Ansi

This should be easy to fix by renaming modules\text_server_fb\gdextension_build\methods.py to something specific.

  • The compilation itself fails due to missing thorvg files, this would likely be due to the SCons file not being up-to-date with changes to the svg module

I can look into fixing the specifics but we should probably evaluate if we want to maintain this functionality as buildable, drop it entirely, or just leave it

Steps to reproduce

Try to build the extension version of either text server module

Minimal reproduction project (MRP)

N/A

@bruvzg
Copy link
Member

bruvzg commented Dec 18, 2024

The compilation itself fails due to missing thorvg files, this would likely be due to the SCons file not being up-to-date with changes to the svg module

Should be fixable by copying file list from svg module`.

@@ -48,7 +48,6 @@ if env["thorvg_enabled"] and env["freetype_enabled"]:
     thirdparty_tvg_sources = [
         # common
         "src/common/tvgCompressor.cpp",
-        "src/common/tvgLines.cpp",
         "src/common/tvgMath.cpp",
         "src/common/tvgStr.cpp",
         # SVG parser
@@ -86,6 +85,7 @@ if env["thorvg_enabled"] and env["freetype_enabled"]:
         "src/renderer/sw_engine/tvgSwImage.cpp",
         "src/renderer/sw_engine/tvgSwMath.cpp",
         "src/renderer/sw_engine/tvgSwMemPool.cpp",
+        "src/renderer/sw_engine/tvgSwPostEffect.cpp",
         "src/renderer/sw_engine/tvgSwRaster.cpp",
         "src/renderer/sw_engine/tvgSwRenderer.cpp",
         "src/renderer/sw_engine/tvgSwRle.cpp",

@AThousandShips
Copy link
Member Author

Will give a fix a test this week and if it's trivial (i.e. a dozen other issues don't arise when fixing these two, won't go whack-a-bug on this) I'll push a fix, otherwise I'll leave it up for discussion

@AThousandShips
Copy link
Member Author

Tried fixing this but ran into some linking errors so won't try to fix this right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: For team assessment
Development

No branches or pull requests

2 participants