Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advertisement on Docs page covers content, including "Next Page" button #10387

Open
mazmystic opened this issue Dec 8, 2024 · 2 comments
Open
Labels
bug content:website Issues related to adding website features and fixing bugs, whether on the front or back-end

Comments

@mazmystic
Copy link

Issue description: EthicalAds advertisement covers some content at the right-hand side of the page, including some text, and fully covering the "Next" button, when the window is within a certain range of widths. On some smaller laptops, that means the advertisement covers the content when in full screen.

URL to the documentation page: https://docs.godotengine.org/en/stable/about/introduction.html or any other docs page without comments.

Steps to recreate: Scroll down until you reach the bottom, and take the window out of fullscreen. Adjust the width of the window. You can observe that there is a range where the advertisement covers content before it disappears.

Proposed Behavior: The advertisement already disappears from the side when the horizontal window size is shrunk to a certain amount. It should be changed to disappear earlier such that the advertisement is never covering content, especially something critical like the "next" button. The advertisement could be moved to the top or bottom of the page, or the top or bottom of the left-hand sidebar.

Current Workaround: Yes, you can click the x button on the advertisement. But this becomes unnecessary friction when it happens every time you click on a page or go to the next page. Godot is known for its good documentation and manual—UX should be included in that (and for the most part, it is.)

@mazmystic mazmystic added the bug label Dec 8, 2024
@mazmystic
Copy link
Author

I am unsure how to add the content:website label, but if someone could tell me how I will do it, or a moderator could do it.

@tetrapod00 tetrapod00 added the content:website Issues related to adding website features and fixing bugs, whether on the front or back-end label Dec 8, 2024
@tetrapod00
Copy link
Contributor

tetrapod00 commented Dec 8, 2024

Thanks for reporting. I can reproduce this pretty easily.

This might be a little out of our hands, since we don't control the advertisements ourselves; they are added by our documentation host, ReadTheDocs. But there are some settings to control where and how the ads are displayed that we can look into.

At some point, this might also be worth reporting to RTD themselves, since both the ad and the next button are present in their default configuration, and the interaction between the two isn't good. But it might not be considered a problem since as you mentioned, you can always close the ad with the x button.

(And labels on issues and PRs are handled by maintainers. I added the content:website label to this one.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug content:website Issues related to adding website features and fixing bugs, whether on the front or back-end
Projects
None yet
Development

No branches or pull requests

2 participants