-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add Chinese Comment Check Workflow to Kratos CI #3422
Comments
|
This situation should not exist in Kratos. I think you can first check if there are any problems in the current warehouse |
There are no issues with the current repo. This workflow is triggered when a contributor creates a PR and checks the submitted code, similar to how Go Test ensures that the submitted content can run properly when a PR is initiated. The check only runs when a PR is opened. If the contributor's code contains Chinese comments, the CI will report an error. |
If you think this issue is not useful, please close it. |
You can submit a PR, add an action, and add a Chinese comment. I would like to see the actual effect |
Fine. I will commit to it later today. |
Hi, @mo3et. I'm Dosu, and I'm helping the Kratos team manage their backlog. I'm marking this issue as stale. Issue Summary
Next Steps
Thank you for your understanding and contribution! |
@shenqidebaozi this PR need to solve. |
@shenqidebaozi, the user @mo3et has indicated that this issue is still relevant and needs your assistance to move forward with the PR for detecting Chinese comments in code. Could you please help them with this? |
Please see the FAQ in our main README.md before submitting your issue.
Requirements description of the feature
I wrote a workflow for our team to check for Chinese comments in the repository when a Pull Request (PR) is opened. The workflow is currently used in our team repo, and you can find it here.
I would like to this workflows is useful to Kratos's workflows. If so, I will submit a PR to integrate this into the repo.
References
workflows details
workflows effect
The text was updated successfully, but these errors were encountered: